fix: Fix breaking change in ui.Select Generic typing
#3002
Merged
+5
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! This pull request can be checked-out with: git fetch origin pull/3002/head:pr-3002
git checkout pr-3002This pull request can be installed with: pip install git+https://github.com/Pycord-Development/pycord@refs/pull/3002/head |
Paillat-dev
requested changes
Nov 14, 2025
discord/ui/select.py
Outdated
|
|
||
| ST = TypeVar("ST", bound="Snowflake | str", covariant=True, default=Any) | ||
| S = TypeVar("S", bound="Select") | ||
| V = TypeVar("V", bound="BaseView", covariant=True) |
Member
There was a problem hiding this comment.
Suggested change
| V = TypeVar("V", bound="BaseView", covariant=True) | |
| V = TypeVar("V", bound="BaseView", covariant=True, default="BaseView") |
Paillat-dev
changed the title
ui.Select Generic typing
Paillat-dev
added
hold: changelog
Member
|
Changelog too pls |
Contributor
Author
ur sure fixing a typehint breaking change needs a changelog ? nice everything will be release at the same time in 2.7 ? |
Co-authored-by: Paillat <jeremiecotti@ik.me> Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>
Member
|
Yes |
Copilot AI
added a commit
that referenced
this pull request
Nov 15, 2025
Co-authored-by: Lumabots <144063653+Lumabots@users.noreply.github.com>
Paillat-dev
approved these changes
Nov 15, 2025
Member
|
thx |
Paillat-dev
removed
the
hold: changelog
Lulalaby
approved these changes
Nov 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Before merging i would like paillat opinion on the rework of the generic, to know if maybe view and modal could be fused as we cant have both at the same time
Information
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.