-
Couldn't load subscription status.
- Fork 560
Fix windows/python/platformdirs issue in GHA #3770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blnicho
approved these changes
Oct 23, 2025
16ad75f to
56212b0
Compare
jsiirola
approved these changes
Oct 24, 2025
|
Merging this: the remaining test failures will be resolved by #3773. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes NA
Summary/Motivation:
I am keeping the commit history on this PR so we can see most of the failed attempts (I had three branches where I was trying a bunch of different things in tandem) for posterity, but TL;DR -
platformdirs4.5.0 seems to cause an inexplicable problem on windows + python 3.13/3.14 + conda/pip mixed environment. This excludes specifically that version so we can make sure to catch if any future versions fix the issue.Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: