-
Notifications
You must be signed in to change notification settings - Fork 54
Documentation update s8 ultra #150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation update s8 ultra #150
Conversation
Lash-L
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good - some reviews that can be addressed in a follow up. Merging this for now just to help with readability and changes
|
oh was gonna merge - but could you run pre-commit. Ignore the lint commit message but the other lint needs to pass |
|
Forgot to change the commit title, but should be okay with my next merge |
Gents, I have done a bit of work to restructure the documentation and provide the basis to extend from. Thank you for the support to get to this point.
The documentation builds cleanly
and is grouped by logical command grouping (acknowledging that this is subjective)
I will continue to make changes (tested on my Roborock s8 Pro Ultra) however will wait until this pull request is approved
Feel free to reach out with questions