Skip to content

Conversation

@allenporter
Copy link
Contributor

Disable the rule that enforces max commit body line length, since i don't think we need it and it is one that always fails for me.

Disable the rule that enforces max commit body line length, since i don't think
we need it and it is one that always fails for me.
Copilot AI review requested due to automatic review settings October 27, 2025 00:19
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR disables the body-max-line-length commit message linting rule to remove the enforcement of maximum line length in commit body text.

  • Adds a new rule configuration to disable body-max-line-length

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

// Disable the rule that enforces lowercase in subject
"subject-case": [0], // 0 = disable, 1 = warn, 2 = error
// Disable the rule that enforces a maximum line length in the body
"body-max-line-length": [0, "always"]
Copy link

Copilot AI Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The second parameter 'always' is unnecessary when disabling a rule (level 0). When a rule is disabled, applicability conditions are ignored. Consider simplifying to [0] for consistency with the subject-case rule above.

Suggested change
"body-max-line-length": [0, "always"]
"body-max-line-length": [0]

Copilot uses AI. Check for mistakes.
@allenporter allenporter merged commit 6a5db1d into Python-roborock:main Oct 27, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants