Test moved to the right module, cleanup, but same problem

Author: dvarrazzo

psycopg/adapter_qstring.c

@@ -87,8 +87,7 @@ qstring_quote(qstringObject *self)
 
     /* if the wrapped object is not a string, this is an error */
     else {
-        PyErr_SetString(PyExc_TypeError,
-                        "can't quote non-string object (or missing encoding)");
+        PyErr_SetString(PyExc_TypeError, "can't quote non-string object");
         goto exit;
     }
 

tests/test_quote.py

@@ -29,6 +29,7 @@
 import psycopg2.extensions
 from psycopg2.extensions import b
 
+
 class QuotingTestCase(ConnectingTestCase):
     r"""Checks the correct quoting of strings and binary objects.
 
@@ -51,7 +52,7 @@ def test_string(self):
         data = """some data with \t chars
         to escape into, 'quotes' and \\ a backslash too.
         """
-        data += "".join(map(chr, range(1,127)))
+        data += "".join(map(chr, range(1, 127)))
 
         curs = self.conn.cursor()
         curs.execute("SELECT %s;", (data,))
@@ -90,13 +91,13 @@ def test_unicode(self):
         if server_encoding != "UTF8":
             return self.skipTest(
                 "Unicode test skipped since server encoding is %s"
-                    % server_encoding)
+                % server_encoding)
 
         data = u"""some data with \t chars
         to escape into, 'quotes', \u20ac euro sign and \\ a backslash too.
         """
-        data += u"".join(map(unichr, [ u for u in range(1,65536)
-            if not 0xD800 <= u <= 0xDFFF ]))    # surrogate area
+        data += u"".join(map(unichr, [u for u in range(1, 65536)
+            if not 0xD800 <= u <= 0xDFFF]))    # surrogate area
         self.conn.set_client_encoding('UNICODE')
 
         psycopg2.extensions.register_type(psycopg2.extensions.UNICODE, self.conn)
@@ -183,9 +184,45 @@ def test_unicode_ident(self):
             self.assertEqual(quote_ident(snowman, self.conn), quoted)
 
 
+class TestStringAdapter(ConnectingTestCase):
+    def test_encoding_default(self):
+        from psycopg2.extensions import adapt
+        a = adapt("hello")
+        self.assertEqual(a.encoding, 'latin1')
+        self.assertEqual(a.getquoted(), "'hello'")
+
+        egrave = u'\xe8'
+        self.assertEqual(adapt(egrave).getquoted(), "'\xe8'")
+
+    def test_encoding_error(self):
+        from psycopg2.extensions import adapt
+        snowman = u"\u2603"
+        a = adapt(snowman)
+        self.assertRaises(UnicodeEncodeError, a.getquoted)
+
+    def test_set_encoding(self):
+        from psycopg2.extensions import adapt
+        snowman = u"\u2603"
+        a = adapt(snowman)
+        a.encoding = 'utf8'
+        self.assertEqual(a.encoding, 'utf8')
+        self.assertEqual(a.getquoted(), "'\xe2\x98\x83'")
+
+    def test_connection_wins_anyway(self):
+        from psycopg2.extensions import adapt
+        snowman = u"\u2603"
+        a = adapt(snowman)
+        a.encoding = 'latin9'
+
+        self.conn.set_client_encoding('utf8')
+        a.prepare(self.conn)
+
+        self.assertEqual(a.encoding, 'utf_8')
+        self.assertEqual(a.getquoted(), "'\xe2\x98\x83'")
+
+
 def test_suite():
     return unittest.TestLoader().loadTestsFromName(__name__)
 
 if __name__ == "__main__":
     unittest.main()
-

tests/test_types_basic.py

@@ -344,43 +344,6 @@ def caster(s, cur):
         self.assertEqual(a, [2,4,'nada'])
 
 
-class TestStringAdapter(ConnectingTestCase):
-    def test_encoding_default(self):
-        from psycopg2.extensions import adapt
-        a = adapt("hello")
-        self.assertEqual(a.encoding, 'latin1')
-        self.assertEqual(a.getquoted(), "'hello'")
-
-        egrave = u'\xe8'
-        self.assertEqual(adapt(egrave).getquoted(), "'\xe8'")
-
-    def test_encoding_error(self):
-        from psycopg2.extensions import adapt
-        snowman = u"\u2603"
-        a = adapt(snowman)
-        self.assertRaises(UnicodeEncodeError, a.getquoted)
-
-    def test_set_encoding(self):
-        from psycopg2.extensions import adapt
-        snowman = u"\u2603"
-        a = adapt(snowman)
-        a.encoding = 'utf8'
-        self.assertEqual(a.encoding, 'utf8')
-        self.assertEqual(a.getquoted(), "'\xe2\x98\x83'")
-
-    def test_connection_wins_anyway(self):
-        from psycopg2.extensions import adapt
-        snowman = u"\u2603"
-        a = adapt(snowman)
-        a.encoding = 'latin9'
-
-        self.conn.set_client_encoding('utf8')
-        a.prepare(self.conn)
-
-        self.assertEqual(a.encoding, 'utf_8')
-        self.assertEqual(a.getquoted(), "'\xe2\x98\x83'")
-
-
 class AdaptSubclassTest(unittest.TestCase):
     def test_adapt_subtype(self):
         from psycopg2.extensions import adapt

tests/testconfig.py

@@ -34,5 +34,3 @@
     dsn += ' user=%s' % dbuser
 if dbpass is not None:
     dsn += ' password=%s' % dbpass
-
-