Skip to content

Conversation

@maroshmka
Copy link
Collaborator

@maroshmka maroshmka commented Aug 1, 2018

Issue - #46

TODO:

  • add order model ❓
  • add photo upload ✅
  • add form, view, etc ✅

@katiayn
Copy link
Member

katiayn commented Aug 1, 2018

@maroshmka about your questions:

  • I removed weight from Volunteers model :) It was used to order the volunteers/speakers in a specific order but now it's gonna be ordered by full_name.
  • You can add the description field to the form so the volunteers can fill this up :)

Thx! 👍


class Meta:
model = Volunteer
exclude = ('active', 'user', 'weight', 'type', 'slug', 'description', )
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove weight (because I remove it) and description (so they can fill this up). 🔝😃

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done :)

if form.is_valid():
volunteer = form.save()
context['success'] = f'{volunteer.full_name}, you have been successfully signed up ' \
f'as a volunteer! Thank you!'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plz, add something else here 🔝

... you have been successfully signed up as a volunteer! 
We will contact you soon.
Thank you! :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done :)

@maroshmka maroshmka force-pushed the hmka/volunteer-create branch from 155ea7a to 8ee3a51 Compare August 5, 2018 11:51
@maroshmka
Copy link
Collaborator Author

Removed weight. Added photo upload. Some minor changes.

I didn't add order-field, cause when migrating, it want to set defaults for order attribute. And i guess there are some data already. But main problem is that in Volunteer model there are organizers + volunteers together, diffed by type attribute. But I guess we want to order only volunteers, or am I wrong?

Possible solution (maybe in another PR?):

  • add TimeStampedModel to Person, order by created_at + filter only volunteers
  • split model Volunteer to - Volunteer and Organizer
  • if we want to order also organizers - add order model + provide default + fix data manually.

what do you think @katiayn?

@katiayn
Copy link
Member

katiayn commented Aug 10, 2018

@maroshmka I already added ordering in in Volunteer, Organizer and Speaker models by full_name. Don't worry about the ordering for now.

Few more things:

  • Plz, rebase to master: we had few changes in the meantime.
  • I added country as a field in Person:
    image
    can you fix the field, plz?
  • check the comment I'll leave here.

Thanks! 😃

path('robots.txt', TemplateView.as_view(template_name='robots.txt', content_type='text/plain')),
path('organizers/<slug:slug>/', organizer_view, name='organizer_detail'),
path('organizers', organizers_listview, name='organizers'),
path('volunteer/create/', volunteer_createview, name='volunteer_create'),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maroshmka let's use volunteers (in plural) to keep the consistence with organizers url. :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@maroshmka maroshmka force-pushed the hmka/volunteer-create branch from 8ee3a51 to 0f50a82 Compare August 12, 2018 18:32
@maroshmka
Copy link
Collaborator Author

rebased and changed urls.

Dont know how to round that select (simple border-radius wont work), it would be faster if someone who knows frontend better than I would look at it.

@katiayn
Copy link
Member

katiayn commented Aug 12, 2018

@maroshmka no problem :) I'll ask some frontend to check it out.

Anyway, thanks! 👍

@katiayn
Copy link
Member

katiayn commented Aug 27, 2018

@maroshmka I changed the link to the form because now they want to have a google form with questions and after they select people, they will fill the volunteers form in the website - the one you created. 😃
They also asked me to remove the button from the main page and add to the organizers page only - for now.

Thanks for your help!

@katiayn katiayn merged commit ff62b67 into master Aug 27, 2018
@maroshmka
Copy link
Collaborator Author

alright :) np

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants