-
Notifications
You must be signed in to change notification settings - Fork 17
Add template, form and view for Volunteer create. #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@maroshmka about your questions:
Thx! 👍 |
pyconbalkan/organizers/forms.py
Outdated
|
|
||
| class Meta: | ||
| model = Volunteer | ||
| exclude = ('active', 'user', 'weight', 'type', 'slug', 'description', ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can remove weight (because I remove it) and description (so they can fill this up). 🔝😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done :)
pyconbalkan/organizers/views.py
Outdated
| if form.is_valid(): | ||
| volunteer = form.save() | ||
| context['success'] = f'{volunteer.full_name}, you have been successfully signed up ' \ | ||
| f'as a volunteer! Thank you!' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Plz, add something else here 🔝
... you have been successfully signed up as a volunteer!
We will contact you soon.
Thank you! :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done :)
155ea7a to
8ee3a51
Compare
|
Removed I didn't add order-field, cause when migrating, it want to set defaults for order attribute. And i guess there are some data already. But main problem is that in Volunteer model there are organizers + volunteers together, diffed by Possible solution (maybe in another PR?):
what do you think @katiayn? |
|
@maroshmka I already added ordering in in Few more things:
Thanks! 😃 |
pyconbalkan/urls.py
Outdated
| path('robots.txt', TemplateView.as_view(template_name='robots.txt', content_type='text/plain')), | ||
| path('organizers/<slug:slug>/', organizer_view, name='organizer_detail'), | ||
| path('organizers', organizers_listview, name='organizers'), | ||
| path('volunteer/create/', volunteer_createview, name='volunteer_create'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maroshmka let's use volunteers (in plural) to keep the consistence with organizers url. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
8ee3a51 to
0f50a82
Compare
|
rebased and changed urls. Dont know how to round that select (simple border-radius wont work), it would be faster if someone who knows frontend better than I would look at it. |
|
@maroshmka no problem :) I'll ask some frontend to check it out. Anyway, thanks! 👍 |
|
@maroshmka I changed the link to the form because now they want to have a google form with questions and after they select people, they will fill the volunteers form in the website - the one you created. 😃 Thanks for your help! |
|
alright :) np |

Issue - #46
TODO: