Add mypy and perform type checks

Author: zanieb

check.py

@@ -49,6 +49,7 @@ def run():
     #   Unused variable
     check_args = ["--select", "I,F401,F841"]
     format_args = []
+    mypy_args = ["pythonbuild"]
 
     if args.fix:
         check_args.append("--fix")
@@ -61,8 +62,13 @@ def run():
     format_result = subprocess.run(
         ["ruff", "format"] + format_args, stdout=sys.stdout, stderr=sys.stderr
     )
+    mypy_result = subprocess.run(
+        ["mypy"] + mypy_args, stdout=sys.stdout, stderr=sys.stderr
+    )
 
-    sys.exit(check_result.returncode + format_result.returncode)
+    sys.exit(
+        check_result.returncode + format_result.returncode + mypy_result.returncode
+    )
 
 
 if __name__ == "__main__":

pythonbuild/docker.py

@@ -9,7 +9,7 @@
 import pathlib
 import tarfile
 
-import docker
+import docker  # type: ignore
 import jinja2
 
 from .logging import log, log_raw
@@ -85,7 +85,7 @@ def get_image(client, source_dir: pathlib.Path, image_dir: pathlib.Path, name):
             return image_id
 
         else:
-            return build_docker_image(client, source_dir, image_dir, name)
+            return build_docker_image(client, str(source_dir).encode(), image_dir, name)
 
 
 def copy_file_to_container(path, container, container_path, archive_path=None):

pythonbuild/utils.py

@@ -202,9 +202,9 @@ def write_target_settings(targets, dest_path: pathlib.Path):
         for key in ("host_cc", "host_cxx", "target_cc", "target_cflags"):
             payload[key] = settings.get(key)
 
-        payload = json.dumps(payload, indent=4).encode("utf-8")
+        serialized_payload = json.dumps(payload, indent=4).encode("utf-8")
 
-        write_if_different(dest_path / triple, payload)
+        write_if_different(dest_path / triple, serialized_payload)
 
 
 class IntegrityError(Exception):
@@ -298,11 +298,17 @@ def download_to_path(url: str, path: pathlib.Path, size: int, sha256: str):
 def download_entry(key: str, dest_path: pathlib.Path, local_name=None) -> pathlib.Path:
     entry = DOWNLOADS[key]
     url = entry["url"]
+    size = entry["size"]
+    sha256 = entry["sha256"]
+
+    assert isinstance(url, str)
+    assert isinstance(size, int)
+    assert isinstance(sha256, str)
 
     local_name = local_name or url[url.rindex("/") + 1 :]
 
     local_path = dest_path / local_name
-    download_to_path(url, local_path, entry["size"], entry["sha256"])
+    download_to_path(url, local_path, size, sha256)
 
     return local_path
 

requirements.dev.in

@@ -1,4 +1,7 @@
+-r requirements.txt
+
 ruff
 mypy
 types-jsonschema
 types-PyYAML
+types-jinja2