Skip to content

set correct "type" of PubSubModerationActionChannelTerms #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 17, 2022
Merged

set correct "type" of PubSubModerationActionChannelTerms #332

merged 7 commits into from
Oct 17, 2022

Conversation

@Dschogo
Copy link
Contributor

@Dschogo Dschogo commented Sep 15, 2022 •
edited
Loading

Pull request summary

Sets a correct/more descriptive "type" of PubSubModerationActionChannelTerms (from "channel_terms_action" to "add_blocked_term"/"delete_blocked_term")

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
    • I have updated the changelog with a quick recap of my changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@Dschogo Dschogo changed the title Patch 1 Fix settings correct/more specific type of PubSubModerationActionChannelTerms Sep 15, 2022
@Dschogo Dschogo changed the title Fix settings correct/more specific type of PubSubModerationActionChannelTerms set correct/more specific type of PubSubModerationActionChannelTerms Sep 15, 2022
@Dschogo Dschogo changed the title set correct/more specific type of PubSubModerationActionChannelTerms set correct/more descriptive "type" of PubSubModerationActionChannelTerms Sep 15, 2022
@chillymosh chillymosh changed the title set correct/more descriptive "type" of PubSubModerationActionChannelTerms set correct "type" of PubSubModerationActionChannelTerms Oct 10, 2022
chillymosh
chillymosh approved these changes Oct 17, 2022
View reviewed changes
Copy link
Collaborator

@chillymosh chillymosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chillymosh chillymosh merged commit 307202c into PythonistaGuild:master Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IAmTomahawkx IAmTomahawkx IAmTomahawkx approved these changes

@chillymosh chillymosh chillymosh approved these changes

+1 more reviewer

@realstealthninja realstealthninja realstealthninja approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Dschogo @IAmTomahawkx @realstealthninja @chillymosh