Skip to content

Conversation

@sam4coding
Copy link
Collaborator

Originally, the default value of "isInference" is 'false'. Whenever the component is rendered, the value of "isInference" is automatically set to false. So it appeared that when we switch out from and then back to "inference" tab, the "start inference" button is activated, as if the inference stopped.
In this update, the variable pair { isInference, setIsInference} is replaced by a new pair { isInferring, setIsInferring }. And they became the prop of the component . The value of "isInferring" is updated solely by "setIsInferring", not by any initializing default value. By this, the status of the "start inference" button is solely determined by the status of inferring.

Copy link
Collaborator

@mansouralawi mansouralawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, issue fixed.

@mansouralawi mansouralawi merged commit d254cd1 into main Aug 6, 2024
@mansouralawi mansouralawi deleted the Inference-keep-going branch August 6, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants