Add valid mask argument and update collate_fn #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarushgupta
changed the title
Collaborator
|
support mitochondria training with distance transform and valid mask. |
donglaiw
pushed a commit
that referenced
this pull request
Nov 14, 2025
…ion configurable
Changes:
1. Phase 2.2: Remove dummy validation dataset workaround (lit_data.py)
- Replaced DummyDataset with proper warning when validation fails
- More honest error handling instead of masking configuration issues
2. Phase 2.3: Make hardcoded deep supervision values configurable (hydra_config.py, lit_model.py)
- Added ModelConfig fields:
* deep_supervision_weights (default: [1.0, 0.5, 0.25, 0.125, 0.0625])
* deep_supervision_clamp_min (default: -20.0)
* deep_supervision_clamp_max (default: 20.0)
- Updated lit_model.py to use configurable values in 3 locations:
* Multi-task output clamping
* Deep supervision output clamping
* Deep supervision scale weights with validation
Benefits:
- Users can now customize deep supervision behavior without code changes
- Removes technical debt items #2 and #4 from REFACTORING_PLAN.md
- Better error handling for missing validation data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.