Skip to content

Conversation

@laylahoogeveen
Copy link
Collaborator

Ticket:

Description of changes

Unable to preview a sub-page if parent page is not published.

image

Presentation mode returns a 404 page when manually adding the URL to the address bar.

How to validate the changes

  • Create a page under an unpublished parent page.
  • Check "link to page". The first part of the slug shouldn't be undefined anymore.
  • Navigate to the page in presentation mode. This shouldn't render a 404 anymore

✅ Definition of Done

This checklist helps with risk management during software development. It is not a mandatory list to fully check off, but a basis for thinking about quality, safety, and best practices. Feel free to adapt it for your own project — as long as the risks are consciously managed.

📄 Documentation & Knowledge Sharing

  • Changes are documented in the code and/or README.md
  • Relevant Notion pages are updated

🧪 Testing & Quality

  • Changes are covered by unit/integration/end-to-end tests
  • GitHub Actions (CI/CD) pass successfully
  • Reviewer has tested and verified the changes locally

📊 Monitoring & Performance

  • Relevant metrics (e.g. in Datadog) are added or updated
  • Performance and scalability have been considered and tested if needed

🔐 Security & Privacy

  • The changes comply with our Secure software development policy
  • No personal data or privacy-sensitive information is affected
  • Input validation, authentication, and authorization are properly handled

🧩 Traceability & Readiness

  • A Jira ticket is linked, and the ticket number is in the PR title (e.g. [R2025-1234] Meaningful title)
  • No unresolved TODOs remain in the code (unless followed up with a Jira ticket)

🤝 Review & Collaboration

  • Code is reviewed by at least one team member
  • Merge responsibility and timing are agreed upon
  • Team members are informed (e.g. via Slack or daily stand-up)

@laylahoogeveen laylahoogeveen added the bug Something isn't working label Sep 19, 2025
Copy link
Collaborator

@stijn-q42 stijn-q42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, easy fix :D

@stijn-q42 stijn-q42 merged commit f8d6ab1 into main Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants