Skip to content

feat(eksanywhere): add cloud credential for eks anywhere#2578

Merged
pggb25 merged 2 commits intostagingfrom
feat/eksanwhere-creds
Apr 7, 2026
Merged

feat(eksanywhere): add cloud credential for eks anywhere#2578
pggb25 merged 2 commits intostagingfrom
feat/eksanwhere-creds

Conversation

@pggb25
Copy link
Copy Markdown
Collaborator

@pggb25 pggb25 commented Apr 7, 2026

Summary

When the eks-anywhere feature flag is enabled, a new type of cluster credential is available.
(feature flag enable on AWS test and not enabled on sandbox)
This is for eks anywhere on vSphere. (same as AWS + vSphere user/password)

Screenshot 2026-04-07 at 14 41 02

Issue:

Screenshots / Recordings

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • yarn format
  • yarn lint

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

@jul-dan
Copy link
Copy Markdown
Contributor

jul-dan commented Apr 7, 2026

Qovery Preview

Qovery can create a Preview Environment for this PR.
To trigger its creation, please post a comment with one of the following command.

Command Blueprint environment
/qovery preview d8a1b661-72ac-4c66-97c9-89bc61392356 test-prod-clone-prod
/qovery preview 8ba67a97-56f5-4655-9090-f29ba94c581f test-prod-clone
/qovery preview 964984c5-fba6-4371-88d3-a5daf99642ab test-prod
/qovery preview cc1de7de-94e5-40f8-8e45-bc8986d9dfec storybook
/qovery preview 28c47145-c8e7-4b9d-8d9e-c65c95b48425 staging
/qovery preview {all|UUID1,UUID2,...} To preview multiple environments

This comment has been generated from Qovery AI 🤖.
Below, a word from its wisdom :

One day they will all understand

@pggb25 pggb25 force-pushed the feat/eksanwhere-creds branch from ae0f605 to 1461846 Compare April 7, 2026 13:59
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 7, 2026

Codecov Report

❌ Patch coverage is 50.52632% with 47 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.72%. Comparing base (187bbaa) to head (771fe7b).
⚠️ Report is 3 commits behind head on staging.

Files with missing lines Patch % Lines
...er-credentials-modal/cluster-credentials-modal.tsx 47.22% 26 Missing and 12 partials ⚠️
...-feature/page-organization-credentials-feature.tsx 66.66% 5 Missing and 2 partials ⚠️
libs/shared/ui/src/lib/components/icon/icon.tsx 0.00% 1 Missing ⚠️
.../ui/src/lib/components/icon/icons/eks-anywhere.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #2578      +/-   ##
===========================================
+ Coverage    47.38%   47.72%   +0.33%     
===========================================
  Files         1230     1281      +51     
  Lines        22904    23826     +922     
  Branches      6801     7037     +236     
===========================================
+ Hits         10853    11370     +517     
- Misses       10001    10297     +296     
- Partials      2050     2159     +109     
Flag Coverage Δ
unittests 47.72% <50.52%> (+0.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

customIconAlt?: string
}

export const ClusterAvatar = forwardRef<ElementRef<typeof Avatar>, ClusterAvatarProps>(function ClusterAvatar(
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you avoid change this component ?
You need to add the icon inside IconEnum, similar with what we've with GitlabIcon for example

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done


const EKS_ANYWHERE_LOGO = '/assets/devicon/eks-anywhere.svg'

const convertToCloudProviderEnum = (cloudProvider: ClusterCredentials['object_type']): CloudProviderEnum => {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If avoid adding props for ClusterAvatar here and add here directly the icon

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

credential?: ClusterCredentials
cloudProvider?: CloudProviderEnum
defaultCredentialType?: ClusterCredentialAuthType
allowedCredentialTypes?: ClusterCredentialAuthType[]
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is mandatory ?
If you can try to avoid adding props

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Copy Markdown
Member

@RemiBonnet RemiBonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pggb25 pggb25 merged commit bca7920 into staging Apr 7, 2026
11 checks passed
@pggb25 pggb25 deleted the feat/eksanwhere-creds branch April 7, 2026 15:40
@RemiBonnet
Copy link
Copy Markdown
Member

🎉 This PR is included in version 1.300.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants