feat(eksanywhere): add cloud credential for eks anywhere#2578
feat(eksanywhere): add cloud credential for eks anywhere#2578
Conversation
|
Qovery can create a Preview Environment for this PR.
This comment has been generated from Qovery AI 🤖.
|
ae0f605 to
1461846
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## staging #2578 +/- ##
===========================================
+ Coverage 47.38% 47.72% +0.33%
===========================================
Files 1230 1281 +51
Lines 22904 23826 +922
Branches 6801 7037 +236
===========================================
+ Hits 10853 11370 +517
- Misses 10001 10297 +296
- Partials 2050 2159 +109
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| customIconAlt?: string | ||
| } | ||
|
|
||
| export const ClusterAvatar = forwardRef<ElementRef<typeof Avatar>, ClusterAvatarProps>(function ClusterAvatar( |
There was a problem hiding this comment.
Could you avoid change this component ?
You need to add the icon inside IconEnum, similar with what we've with GitlabIcon for example
|
|
||
| const EKS_ANYWHERE_LOGO = '/assets/devicon/eks-anywhere.svg' | ||
|
|
||
| const convertToCloudProviderEnum = (cloudProvider: ClusterCredentials['object_type']): CloudProviderEnum => { |
There was a problem hiding this comment.
If avoid adding props for ClusterAvatar here and add here directly the icon
| credential?: ClusterCredentials | ||
| cloudProvider?: CloudProviderEnum | ||
| defaultCredentialType?: ClusterCredentialAuthType | ||
| allowedCredentialTypes?: ClusterCredentialAuthType[] |
There was a problem hiding this comment.
This one is mandatory ?
If you can try to avoid adding props
|
🎉 This PR is included in version 1.300.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Summary
When the eks-anywhere feature flag is enabled, a new type of cluster credential is available.
(feature flag enable on AWS test and not enabled on sandbox)
This is for eks anywhere on vSphere. (same as AWS + vSphere user/password)
Issue:
Screenshots / Recordings
Testing
yarn testoryarn test -u(if you need to regenerate snapshots)yarn formatyarn lintPR Checklist
.cursor/rules)feat(service): add new Terraform service) - required for semantic-release