Skip to content

fix(obs): fix status value in HTTP error rate board (envoy)#2599

Merged
RemiBonnet merged 1 commit intostagingfrom
fix/http-error-status
Apr 14, 2026
Merged

fix(obs): fix status value in HTTP error rate board (envoy)#2599
RemiBonnet merged 1 commit intostagingfrom
fix/http-error-status

Conversation

@pggb25
Copy link
Copy Markdown
Collaborator

@pggb25 pggb25 commented Apr 14, 2026

Summary

Issue:

Screenshots / Recordings

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • yarn format
  • yarn lint

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 14, 2026

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.91%. Comparing base (057278f) to head (7667805).
⚠️ Report is 2 commits behind head on staging.

Files with missing lines Patch % Lines
...e-http-errors-chart/instance-http-errors-chart.tsx 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #2599      +/-   ##
===========================================
+ Coverage    47.45%   48.91%   +1.46%     
===========================================
  Files         1231      409     -822     
  Lines        23041     9837   -13204     
  Branches      6848     3015    -3833     
===========================================
- Hits         10934     4812    -6122     
+ Misses       10044     4102    -5942     
+ Partials      2063      923    -1140     
Flag Coverage Δ
unittests 48.91% <0.00%> (+1.46%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@RemiBonnet RemiBonnet merged commit cb488d7 into staging Apr 14, 2026
11 checks passed
@RemiBonnet RemiBonnet deleted the fix/http-error-status branch April 14, 2026 14:51
@RemiBonnet
Copy link
Copy Markdown
Member

🎉 This PR is included in version 1.301.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants