Skip to content

fix(alerts): update alert edition condition#2613

Merged
rmnbrd merged 1 commit intostagingfrom
fix/alerts/alert-update-issue
Apr 21, 2026
Merged

fix(alerts): update alert edition condition#2613
rmnbrd merged 1 commit intostagingfrom
fix/alerts/alert-update-issue

Conversation

@rmnbrd
Copy link
Copy Markdown
Contributor

@rmnbrd rmnbrd commented Apr 21, 2026

Summary

Issue: Following #2606, we've seen that the same fix needed to be applied to alert edition modal.

Screenshots / Recordings

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • yarn format
  • yarn lint

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

@rmnbrd rmnbrd self-assigned this Apr 21, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 21, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 41.08%. Comparing base (c48b467) to head (dc40980).
⚠️ Report is 3 commits behind head on staging.

Files with missing lines Patch % Lines
...erting-edit-feature/page-alerting-edit-feature.tsx 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (c48b467) and HEAD (dc40980). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (c48b467) HEAD (dc40980)
unittests 2 1
Additional details and impacted files
@@             Coverage Diff              @@
##           staging    #2613       +/-   ##
============================================
- Coverage    51.75%   41.08%   -10.68%     
============================================
  Files           16       64       +48     
  Lines          199     1385     +1186     
  Branches        53      440      +387     
============================================
+ Hits           103      569      +466     
- Misses          79      650      +571     
- Partials        17      166      +149     
Flag Coverage Δ
unittests 41.08% <0.00%> (-10.68%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rmnbrd rmnbrd marked this pull request as ready for review April 21, 2026 15:02
@rmnbrd rmnbrd requested review from RemiBonnet and Copilot April 21, 2026 15:02
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the alert editing page logic to mirror the fix introduced in #2606 by allowing HTTP-route-based services (Envoy/HTTPRoute) to satisfy the “HTTP metrics can be edited” prerequisite, not only ingress-based services.

Changes:

  • Update the submit guard in the alert edit flow to accept httpRouteName as an alternative to ingressName.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@rmnbrd rmnbrd merged commit db9f3a9 into staging Apr 21, 2026
14 of 15 checks passed
@rmnbrd rmnbrd deleted the fix/alerts/alert-update-issue branch April 21, 2026 15:18
@RemiBonnet
Copy link
Copy Markdown
Member

🎉 This PR is included in version 1.302.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants