fix(alerts): update alert edition condition#2613
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## staging #2613 +/- ##
============================================
- Coverage 51.75% 41.08% -10.68%
============================================
Files 16 64 +48
Lines 199 1385 +1186
Branches 53 440 +387
============================================
+ Hits 103 569 +466
- Misses 79 650 +571
- Partials 17 166 +149
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR updates the alert editing page logic to mirror the fix introduced in #2606 by allowing HTTP-route-based services (Envoy/HTTPRoute) to satisfy the “HTTP metrics can be edited” prerequisite, not only ingress-based services.
Changes:
- Update the submit guard in the alert edit flow to accept
httpRouteNameas an alternative toingressName.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
🎉 This PR is included in version 1.302.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Summary
Issue: Following #2606, we've seen that the same fix needed to be applied to alert edition modal.
Screenshots / Recordings
Testing
yarn testoryarn test -u(if you need to regenerate snapshots)yarn formatyarn lintPR Checklist
.cursor/rules)feat(service): add new Terraform service) - required for semantic-release