Skip to content

fix(services): rename CPU architecture "Default" option to "Any"#2794

Merged
fabienfleureau merged 1 commit into
stagingfrom
fix/cpu-architecture-default-to-any
Jul 3, 2026
Merged

fix(services): rename CPU architecture "Default" option to "Any"#2794
fabienfleureau merged 1 commit into
stagingfrom
fix/cpu-architecture-default-to-any

Conversation

@fabienfleureau

@fabienfleureau fabienfleureau commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator

Summary

Issue:

Screenshots / Recordings

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • yarn format
  • yarn lint

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

Copilot AI review requested due to automatic review settings July 3, 2026 12:41

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Renames the CPU architecture dropdown’s “Default” option to “Any” in the service resources settings UI, clarifying that the default selection is not a specific architecture.

Changes:

  • Updated the CPU architecture options label from “Default” to “Any” while keeping the underlying value as DEFAULT.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov

codecov Bot commented Jul 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 43.42%. Comparing base (042b859) to head (c4f853e).

Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #2794      +/-   ##
===========================================
- Coverage    47.17%   43.42%   -3.76%     
===========================================
  Files         1200      461     -739     
  Lines        25644    12078   -13566     
  Branches      7621     3738    -3883     
===========================================
- Hits         12098     5245    -6853     
+ Misses       11461     5888    -5573     
+ Partials      2085      945    -1140     
Flag Coverage Δ
unittests 43.42% <ø> (-3.76%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fabienfleureau fabienfleureau merged commit 884df5e into staging Jul 3, 2026
14 of 15 checks passed
@fabienfleureau fabienfleureau deleted the fix/cpu-architecture-default-to-any branch July 3, 2026 12:58
@RemiBonnet

Copy link
Copy Markdown
Member

🎉 This PR is included in version 1.326.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants