fix(organizations): allow custom git branch selection#2800
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## staging #2800 +/- ##
===========================================
- Coverage 46.92% 45.49% -1.44%
===========================================
Files 1251 632 -619
Lines 26771 15453 -11318
Branches 7804 4587 -3217
===========================================
- Hits 12562 7030 -5532
+ Misses 12052 7219 -4833
+ Partials 2157 1204 -953
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
c1953b0 to
e94b615
Compare
rmnbrd
approved these changes
Jul 7, 2026
Comment on lines
+59
to
+68
| const branchOptionsWithSelectedValue = | ||
| !disabled && watchFieldBranch && !branchOptions.some((branch) => branch.value === watchFieldBranch) | ||
| ? [ | ||
| ...branchOptions, | ||
| { | ||
| label: watchFieldBranch, | ||
| value: watchFieldBranch, | ||
| }, | ||
| ] | ||
| : branchOptions |
Contributor
There was a problem hiding this comment.
Can we memoize this variable?
e94b615 to
de0eef6
Compare
de0eef6 to
847dc09
Compare
Member
Author
|
🎉 This PR is included in version 1.326.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow users to manually select a Git branch even when it is not returned by the API.
https://qovery.slack.com/archives/C0A4CDDJBRQ/p1783347250876129
Screenshots / Recordings
branch.mov
Testing
yarn testoryarn test -u(if you need to regenerate snapshots)yarn formatyarn lintPR Checklist
.cursor/rules)feat(service): add new Terraform service) - required for semantic-release