Skip to content

fix(organizations): allow custom git branch selection#2800

Merged
RemiBonnet merged 1 commit into
stagingfrom
fix/allow-custom-git-branch
Jul 7, 2026
Merged

fix(organizations): allow custom git branch selection#2800
RemiBonnet merged 1 commit into
stagingfrom
fix/allow-custom-git-branch

Conversation

@RemiBonnet

@RemiBonnet RemiBonnet commented Jul 6, 2026

Copy link
Copy Markdown
Member

Summary

Allow users to manually select a Git branch even when it is not returned by the API.
https://qovery.slack.com/archives/C0A4CDDJBRQ/p1783347250876129

Screenshots / Recordings

branch.mov

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • yarn format
  • yarn lint

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

@codecov

codecov Bot commented Jul 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 45.49%. Comparing base (4716826) to head (847dc09).
⚠️ Report is 3 commits behind head on staging.

Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #2800      +/-   ##
===========================================
- Coverage    46.92%   45.49%   -1.44%     
===========================================
  Files         1251      632     -619     
  Lines        26771    15453   -11318     
  Branches      7804     4587    -3217     
===========================================
- Hits         12562     7030    -5532     
+ Misses       12052     7219    -4833     
+ Partials      2157     1204     -953     
Flag Coverage Δ
unittests 45.49% <100.00%> (-1.44%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@RemiBonnet RemiBonnet force-pushed the fix/allow-custom-git-branch branch 2 times, most recently from c1953b0 to e94b615 Compare July 7, 2026 07:22
@RemiBonnet RemiBonnet marked this pull request as ready for review July 7, 2026 07:30
Comment on lines +59 to +68
const branchOptionsWithSelectedValue =
!disabled && watchFieldBranch && !branchOptions.some((branch) => branch.value === watchFieldBranch)
? [
...branchOptions,
{
label: watchFieldBranch,
value: watchFieldBranch,
},
]
: branchOptions

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we memoize this variable?

@RemiBonnet RemiBonnet force-pushed the fix/allow-custom-git-branch branch from e94b615 to de0eef6 Compare July 7, 2026 07:40
@RemiBonnet RemiBonnet force-pushed the fix/allow-custom-git-branch branch from de0eef6 to 847dc09 Compare July 7, 2026 07:44
@RemiBonnet RemiBonnet merged commit fd6bc48 into staging Jul 7, 2026
11 of 12 checks passed
@RemiBonnet RemiBonnet deleted the fix/allow-custom-git-branch branch July 7, 2026 07:51
@RemiBonnet

Copy link
Copy Markdown
Member Author

🎉 This PR is included in version 1.326.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants