fix BranchFixB gadget #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # ⋅ ● ⋅ ⋅ | ||
| function source_graph(::BranchFixB) | ||
| locs = SimpleNode.([(2,3),(3,3),(3,2),(4,2)]) | ||
| locs = SimpleNode.([(2,3),(3,2),(3,3),(4,2)]) |
Contributor
There was a problem hiding this comment.
Why does the ordering of the vertices matter in the array?
Contributor
Author
There was a problem hiding this comment.
Good question. Because it is related to how I specify the graph. They should be consistent. See line 262.
For regular unit disk gadgets, it does not matter, however, it topology of a crossing gadget has to be specified manually. So they should be consistent.
Contributor
Author
There was a problem hiding this comment.
If you feel this PR is good, you can either approve or squash and merge this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in the mapping. The
BranchFixBgadget does not describe the graph correctly. @minhthin1028