Adding wrappers + fixing test. #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds wrappers around grid operations and updates tests to use the new wrappers while improving type inference. Key changes include:
- Updating test files (test_typeinfer.py and test_concrete.py) to use new grid wrapper functions and adjusted import paths.
- Introducing a new interface file (_interface.py) that provides wrapped grid operations.
- Adjusting module exports and updating the project’s coverage configuration in pyproject.toml.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/grid/test_typeinfer.py | Updated tests to use grid.new with type inference and renamed test functions. |
| test/grid/test_concrete.py | Updated import paths for grid module. |
| src/bloqade/geometry/dialects/grid/_interface.py | Added wrappers for grid operations and associated type annotations. |
| src/bloqade/geometry/dialects/grid/init.py | Re-exported new interface functions. |
| src/bloqade/geometry/init.py | Simplified grid import. |
| pyproject.toml | Updated coverage report settings to exclude certain decorators. |
Comments suppressed due to low confidence (1)
test/grid/test_typeinfer.py:13
- [nitpick] Consider using a more descriptive function name instead of 'test_1' to clarify the intent of the test.
def test_1(spacing: ilist.IList[float, Literal[2]]):
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
weinbe58
added a commit
that referenced
this pull request
May 9, 2025
* adding wrappers * reexporting wrappers * fixing test * Update src/bloqade/geometry/dialects/grid/_interface.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.