Skip to content

Type checking for #535 #536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 16, 2025
Merged

Type checking for #535 #536

merged 2 commits into from
Oct 16, 2025

Conversation

@cduck
Copy link
Contributor

@cduck cduck commented Oct 16, 2025

No description provided.

@cduck cduck requested a review from Roger-luo October 16, 2025 21:10
@github-actions
Copy link
Contributor

github-actions bot commented Oct 16, 2025 •
edited
Loading

PR Preview Action v1.6.2
Preview removed because the pull request was closed.
2025-10-16 22:50 UTC

@codecov
Copy link

codecov bot commented Oct 16, 2025

Codecov Report

❌ Patch coverage is 79.31034% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/kirin/dialects/scf/stmts.py 54.54% 5 Missing ⚠️
src/kirin/ir/exception.py 75.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@github-actions
Copy link
Contributor

github-actions bot commented Oct 16, 2025

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
11333 10107 89% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
src/kirin/dialects/scf/scf2cf.py 98% 🟢
src/kirin/dialects/scf/stmts.py 82% 🟢
src/kirin/ir/exception.py 93% 🟢
src/kirin/lowering/frame.py 94% 🟢
src/kirin/rewrite/walk.py 93% 🟢
TOTAL 92% 🟢

updated for commit: 5315b04 by action🐍

@Roger-luo
Copy link
Collaborator

Roger-luo commented Oct 16, 2025

I think this PR is a very good example why we want to move to a compiled language eventually...

@Roger-luo Roger-luo merged commit f711b84 into main Oct 16, 2025
11 of 13 checks passed
@Roger-luo Roger-luo deleted the cduck/isinstance-main branch October 16, 2025 22:50
@zhenrongliew zhenrongliew mentioned this pull request Oct 22, 2025
Merged
Roger-luo pushed a commit that referenced this pull request Oct 22, 2025
@zhenrongliew
Fix Pyright complains from #535 and #536 (#539)
8046478 
Fix Pyright complains from #535 and #536 (that removed`isinstance`
causing performance issue).
Casts to correct type so pyright doesn't complain
This was referenced Oct 23, 2025
Closed
Merged
Roger-luo pushed a commit that referenced this pull request Oct 23, 2025
@cduck @Roger-luo
Type checking for #535 (#536)
35b2419
Roger-luo pushed a commit that referenced this pull request Oct 23, 2025
@zhenrongliew @Roger-luo
Fix Pyright complains from #535 and #536 (#539)
97f77d9 
Fix Pyright complains from #535 and #536 (that removed`isinstance`
causing performance issue).
Casts to correct type so pyright doesn't complain
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Roger-luo Roger-luo Roger-luo approved these changes

Assignees

No one assigned

Labels

backport 0.17

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cduck @Roger-luo