Skip to content

Conversation

@Martin-Molinero
Copy link
Member

@Martin-Molinero Martin-Molinero commented Jul 11, 2023

Description

  • Fix live option chain sources handling
  • Reuse http client for option chain requests
  • Lazy rate gate initialization

Related Issue

See #6394

Motivation and Context

In live trading the option chain sources could be outdated since they might of been sourced only from disk

Requires Documentation Change

N/A

How Has This Been Tested?

Existing unit tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

- Fix live option chain sources handling
Copy link
Member

@jaredbroad jaredbroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run the discussed test

@Martin-Molinero
Copy link
Member Author

Please run the discussed test

MASTER

Returning 12020 contract(s) for SPX

PR

Returning 12258 contract(s) for SPX

@Martin-Molinero Martin-Molinero merged commit 54413e9 into QuantConnect:master Jul 11, 2023
@Martin-Molinero Martin-Molinero deleted the bug-live-option-chain-source branch July 11, 2023 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants