issue_250_software_engineering #262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jonah-Heyl
commented
Jul 20, 2023
Contributor
Author
Jonah-Heyl
left a comment
Jonah-Heyl
left a comment
There was a problem hiding this comment.
I add mu to the format_myst.jl dictionary
Jonah-Heyl
changed the title
Jonah-Heyl
changed the title
jlperla
reviewed
Jul 24, 2023
| function foo(μ = 1., σ = 2.) | ||
| d = Normal(μ, σ) | ||
| function foo(;mu = 1., sigma = 2.) |
Member
There was a problem hiding this comment.
I would turn this back to foo(mu = 1., sigma = 2.)
YOu don't want to use keyword only functions very often. Just for those convenience constructors and occiaonlly a few other things.
Contributor
Author
There was a problem hiding this comment.
I have changed this and gone through and changed the function calls as well.
| * Modify the `foo` function definition to add `println("Modified foo definition")` inside the function | ||
| ```{code-block} julia | ||
| function foo(μ = 1., σ = 2.) | ||
| function foo(;mu = 1., sigma = 2.) |
Member
There was a problem hiding this comment.
Same thing here and beyond. Don't use a kw only arguemnts.
Jonah-Heyl
commented
Jul 24, 2023
Contributor
Author
Jonah-Heyl
left a comment
Jonah-Heyl
left a comment
There was a problem hiding this comment.
In testing.md what should be done about the function on lines 140-148. The julia is v"1.8"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.