Skip to content

Conversation

@nisha617
Copy link
Collaborator

@nisha617 nisha617 commented Sep 5, 2025

This PR updates the translation in opt_transport.md.

There is some error in Python code.

@netlify
Copy link

netlify bot commented Sep 5, 2025

Deploy Preview for astonishing-narwhal-a8fc64 ready!

Name Link
🔨 Latest commit 44319f4
🔍 Latest deploy log https://app.netlify.com/projects/astonishing-narwhal-a8fc64/deploys/68c2a846eb946000081ee17b
😎 Deploy Preview https://deploy-preview-58--astonishing-narwhal-a8fc64.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link

github-actions bot commented Sep 5, 2025

@github-actions github-actions bot temporarily deployed to pull request September 5, 2025 14:37 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 6, 2025 13:01 Inactive
@mmcky mmcky requested a review from Copilot September 10, 2025 02:08
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Chinese translation of the optimal transport lecture file (opt_transport.md). The main purpose is to correct errors in the Python code and improve the quality of the Chinese translation.

  • Improved translation consistency and clarity throughout the document
  • Fixed Chinese grammar and expression issues
  • Updated code comments to Chinese and corrected some technical explanations
Comments suppressed due to low confidence (1)

lectures/opt_transport.md:1

  • The pip install commands are missing proper code cell formatting. These installation commands should be in their own code cell block to ensure proper execution in Jupyter notebooks.
---

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions github-actions bot temporarily deployed to pull request September 10, 2025 13:45 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 10, 2025 14:06 Inactive
@nisha617
Copy link
Collaborator Author

@mmcky @HumphreyYang

There is an error in the following Python code (which is the same as in the English version):

import ot

We can merge this PR once it is fixed.

@github-actions github-actions bot temporarily deployed to pull request September 11, 2025 10:57 Inactive
@HumphreyYang
Copy link
Member

HumphreyYang commented Sep 11, 2025

Hi @nisha617,

The error is now fixed!

One thing I noticed is that the beginning sentence of the lecture gives a "machine-translated" feeling.

I think this is a common issue with Claude translated lectures.
So I often rewrite the beginning by changing the wording : )

@nisha617 nisha617 merged commit 2982115 into main Sep 18, 2025
6 checks passed
@nisha617 nisha617 deleted the opt_transport branch September 18, 2025 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants