Make edits in the lecture to solve an issue #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This edit changed map to applymap to make it accessible in the WASM environment
Collaborator
|
Thanks @bishmaybarik. @mmcky shall I also update the CI file to run preview deployments on |
Contributor
Also happy for you to merge this to main if easier. |
Contributor
|
@kp992 can you change the target to |
Collaborator
|
I tried changing the target but makes it harder to review because of large diff. Let's merge this in edits branch and we can verify it with all other changes. |
Contributor
|
thanks @kp992 please go ahead. I have reviewed both change sets and happy with them. Thanks @bishmaybarik |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This edit changed
.mapto.applymapto make it accessible in the WASM environment.FIxes #24