Skip to content

Conversation

Hind-M
Copy link
Member

@Hind-M Hind-M commented Jun 18, 2025

No description provided.

@Hind-M Hind-M force-pushed the generate_headers branch from edbe676 to 8efbca8 Compare June 18, 2025 08:57
@Alex-PLACET
Copy link
Member

Can you add a first step for the CI, like compiling a test on Linux ?

CMakeLists.txt Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add a mechanism to fecth this executable

CMakeLists.txt Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In another PR, you should add mechanism to download automatically these dependencies, as in Sparrow.
Then, in a next PR, we should add dependencies manager likke VCPKG and conan

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I get what you mean with the mechanism to download dependencies automatically.
Can you point to what you have in mind in sparrow's codebase?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hind-M Hind-M force-pushed the generate_headers branch from 8efbca8 to bf39486 Compare June 19, 2025 07:38
@Hind-M
Copy link
Member Author

Hind-M commented Jun 19, 2025

Can you add a first step for the CI, like compiling a test on Linux ?

I just added a first workflow to run on linux, but it's not triggered. I suppose having no workflows in main prevents it from running for now...

@Hind-M Hind-M marked this pull request as ready for review June 19, 2025 12:43
@Hind-M Hind-M merged commit 6d85f52 into QuantStack:main Jun 20, 2025
@Hind-M Hind-M deleted the generate_headers branch June 20, 2025 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants