Skip to content

Conversation

@AndreasAlbertQC
Copy link
Collaborator

Motivation

Implements #160

Changes

  • Removed warning for nullable primary keys
  • Changed behavior such that attempts to declare nullable primary key columns raise a hard errror

@AndreasAlbertQC AndreasAlbertQC added this to the v2 milestone Oct 17, 2025
@github-actions github-actions bot added breaking enhancement New feature or request labels Oct 17, 2025
@AndreasAlbertQC AndreasAlbertQC marked this pull request as ready for review October 17, 2025 12:40
@AndreasAlbertQC AndreasAlbertQC changed the title feat!: Raise errors on nullable primary keys feat!: Raise error on nullable primary key Oct 17, 2025
@codecov
Copy link

codecov bot commented Oct 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (ab5224b) to head (2f08d5e).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #173   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           50        50           
  Lines         2901      2897    -4     
=========================================
- Hits          2901      2897    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AndreasAlbertQC AndreasAlbertQC enabled auto-merge (squash) October 17, 2025 15:06
@AndreasAlbertQC AndreasAlbertQC merged commit 4c2bac7 into main Oct 17, 2025
22 checks passed
@AndreasAlbertQC AndreasAlbertQC deleted the 2025-10-17_nullable-pk branch October 17, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Schema class creation should fail if nullable primary key is declared

3 participants