Skip to content

Conversation

@AndreasAlbertQC
Copy link
Collaborator

@AndreasAlbertQC AndreasAlbertQC commented Oct 17, 2025

Motivation

Implements #20

Changes

  • Changed the default of nullable from True to False
  • Replaced FutureWarning
  • Added a test for the skip_if decorator we otherwise don't use anymore right now. I expect we will use it again for future deprecations, so I figured it should stay in the code base.

@AndreasAlbertQC AndreasAlbertQC marked this pull request as ready for review October 17, 2025 12:52
@AndreasAlbertQC AndreasAlbertQC marked this pull request as draft October 17, 2025 13:18
@codecov
Copy link

codecov bot commented Oct 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (53c72bd) to head (40a2dcc).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #174   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           50        50           
  Lines         2904      2894   -10     
=========================================
- Hits          2904      2894   -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AndreasAlbertQC AndreasAlbertQC added this to the v2 milestone Oct 17, 2025
Base automatically changed from 2025-10-17_nullable-pk to main October 17, 2025 15:08
@github-actions github-actions bot added breaking enhancement New feature or request labels Oct 17, 2025
@AndreasAlbertQC AndreasAlbertQC marked this pull request as ready for review October 17, 2025 16:00
Copy link
Member

@borchero borchero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat, just small questions related to the tests

@borchero borchero linked an issue Oct 18, 2025 that may be closed by this pull request
Copy link
Member

@delsner delsner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good modulo @borchero's questions.

Co-authored-by: Daniel Elsner <daniel.elsner@quantco.com>
Copy link
Member

@borchero borchero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation!

@AndreasAlbertQC AndreasAlbertQC merged commit 7dfaf88 into main Oct 20, 2025
24 checks passed
@AndreasAlbertQC AndreasAlbertQC deleted the 2025-10-17_nullable-default branch October 20, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make nullable=False the default

3 participants