-
Couldn't load subscription status.
- Fork 13
feat!: Make columns non-nullable by default #174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #174 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 50 50
Lines 2904 2894 -10
=========================================
- Hits 2904 2894 -10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat, just small questions related to the tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good modulo @borchero's questions.
Co-authored-by: Daniel Elsner <daniel.elsner@quantco.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the explanation!
Motivation
Implements #20
Changes
nullablefromTruetoFalseFutureWarningskip_ifdecorator we otherwise don't use anymore right now. I expect we will use it again for future deprecations, so I figured it should stay in the code base.