refactor!: Rename sql_schema to sqlalchemy_columns and prefix all conversion functions with to_
#183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #183 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 50 50
Lines 2918 2915 -3
=========================================
- Hits 2918 2915 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
borchero
changed the title
sql_schema to sqlalchemy_schemasql_schema to sqlalchemy_columns
borchero
changed the title
sql_schema to sqlalchemy_columnssql_schema to sqlalchemy_columns and prefix all conversion functions with to_
|
@AndreasAlbertQC @delsner PTAL :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #181. @delsner and I decided to additionally replace
schemawithcolumnsas this feels more appropriate for what is being returned here.