Skip to content

Conversation

@borchero
Copy link
Member

Motivation

Dataframely v2 fails with polars 1.35.

Changes

This doesn't actually change anything but, somehow, polars infers flags incorrectly.

However, we should look into our nightly CI which did not catch this regression, unfortunately.

@borchero borchero self-assigned this Oct 28, 2025
@github-actions github-actions bot added the fix label Oct 28, 2025
@codecov
Copy link

codecov bot commented Oct 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (f663bfb) to head (ae5e8f1).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #207   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           53        53           
  Lines         3005      3005           
=========================================
  Hits          3005      3005           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@borchero
Copy link
Member Author

Polars 1.35.0 was pulled on PyPI, waiting until there is a new version

@AndreasAlbertQC
Copy link
Collaborator

Once the new version is ready, we need to remember to bump the pins here and here, which already seem to have diverged

@borchero
Copy link
Member Author

In polars 1.35.1, this is actually not broken, just another test case testing for string equality. I'm closing this one in favor of a new one

@borchero borchero closed this Oct 30, 2025
@borchero
Copy link
Member Author

borchero commented Oct 30, 2025

Once the new version is ready, we need to remember to bump the pins here and here, which already seem to have diverged

I'm not sure I fully agree. We shouldn't bump the version in pyproject.toml to 1.35 since we do not require polars 1.35 by the user. pixi.toml should probably pin to a version >= the one in the pyproject.toml but I'd also say they don't need to align.

That being said: potentially, it makes sense to add tests for the minimum supported polars version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants