feat: Package extension for StaticArray#39
Merged
Merged
Conversation
Member
|
LGTM. Do you think it might be worth testing how |
Member
Author
|
Maybe, but I seem to recall that Mooncake had some issues with it and I'm not sure I really have the bandwidth to start tackling that right now anyways |
Member
|
Thanks; this went quick and looks surprisingly simple. I haven't had time for any code reviews since yesterday yet. I always kinda felt like StaticArrays should have a VectorInterface extension, but since this is outside my control, I guess a StaticArrays extension was unavoidable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #32 by adding a package extension that dispatches the
f!!functions to thefinstead off!ones.I just did the minimal amount of work + tests to make this work, but if we ever run into more of these issues, it might be easier to just generalize this and have some trait-based system to more generally handle this.