Skip to content

Conversation

@JamesDurham
Copy link
Contributor

left some residue for comparison purposes.

left some residue for comparison purposes.
@JamesDurham
Copy link
Contributor Author

From reply note

As far as code coverage is concerned, I can only do so much. I’ll hit stuff, based upon request. There is no way to do unit tests on a fluent interface. This is because it is a mini language, not a unit. There are ways to test languages the way you want. I just don’t know them.

I’ll be doing a pull request, with what I think is what you are wanting.... I don’t know where the this variable thing is coming from, could you specify a file.

Tell me if I missed anything.

Also, let me know about anything else you want changed or added.

Copy link
Member

@berbschloe berbschloe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good, go ahead and merge these into master

@JamesDurham JamesDurham merged commit d89b624 into master Dec 24, 2016
@JamesDurham JamesDurham deleted the Branch_master branch December 24, 2016 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants