Refactor #2
Merged
Refactor #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
…complexity - Create ConsoleOutput.vue for overlay display functionality - Create ConsoleToggle.vue for toggle button with clean interface - Remove confusing toggleOnly/overlayOnly props abstraction - Clear separation: toggle shows state, output manages overlay - Extract all console-related logic and styling from App.vue - Reduce App.vue by ~100 lines with better separation of concerns 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Create AppHeader.vue with title, subtitle, and GitHub link functionality - Create RunButton.vue with dynamic state and version display - Remove 445 lines from App.vue (57% reduction: 776→331 lines) - Clean 2-level component hierarchy with focused responsibilities - Each component handles its own state and styling Components now extracted: - AppHeader: GitHub API, stars, title display - RunButton: execution state, version info, dynamic styling - ConsoleOutput: message overlay display - ConsoleToggle: console toggle button with error states 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Show "Running..." instead of "Console (0)" when code is executing - Disable button and prevent clicks during loading state - Hide toggle arrow when running since interaction unavailable - Add muted styling for loading state with proper visual feedback - Maintain error/warning state priority over loading state 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
…concerns - Extract pure WebR modules without Vue dependencies to src/webr/ - Create layered architecture: Core → Runtime → Storage → Utils - Replace complex composables with clean, testable modules - Fix output processing to handle R condition objects properly - Add proper TypeScript types throughout, eliminate 'any' usage - Implement consistent error handling with cleanup - Add comprehensive WebR API documentation references Key improvements: - WebRInstance: Clean lifecycle management - Executor: Robust code execution with proper output capture - OutputProcessor: Fixed INFO/WARNING message categorization - Serializer: Handles complex R objects with fallback strategies - PackageManager: Tracks installations with version info - FileSystem: Virtual filesystem operations Output now correctly shows: - INFO: `geom_smooth()` using formula = 'y ~ x' - WARNING: Clean warning messages without duplication 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Untangling code, making it well designed