Skip to content

Conversation

@Vladlukhanin
Copy link
Contributor

Make sure that you wrote the tests for your proposed changes and the existing test was success.

Made/Proposed changes:

  • roster[key] is 'userId' instead of attr 'name' (roster keys must be user ids, not userId + appId);
  • updated test for method 'get' in Roster;
  • changed sdk version to 2.3.1.

How should this be manually tested?

  • run jasmine test.

Does the documentation need an update?

  • no.

@Vladlukhanin Vladlukhanin merged commit 498afe7 into gh-pages Sep 29, 2016
@Vladlukhanin Vladlukhanin deleted the gh-pages.roster branch September 29, 2016 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants