Develop.sprint6.separate calls #186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimaspirit
reviewed
Dec 7, 2016
samples/webrtc/js/app.js
Outdated
| app.helpers.stateBoard.update({'title': 'calling'}); | ||
|
|
||
| document.getElementById(sounds.call).play(); | ||
| // document.getElementById(sounds.call).play(); |
Contributor
There was a problem hiding this comment.
Why do you need commented?
dimaspirit
reviewed
Dec 7, 2016
samples/webrtc/js/app.js
Outdated
|
|
||
| /** ACCEPT */ | ||
| $(document).on('click', '.j-accept', function() { | ||
| isAudio = app.currentSession.callType === 2; |
Contributor
There was a problem hiding this comment.
Better use const
QB.webrtc.CallType.VIDEO
Contributor
Author
There was a problem hiding this comment.
You mean QB.webrtc.CallType.AUDIO. Yes, it's a good idea.
dimaspirit
reviewed
Dec 7, 2016
samples/webrtc/js/app.js
Outdated
| app.helpers.stateBoard.update({'title': 'create_session'}); | ||
| app.currentSession = QB.webrtc.createNewSession(Object.keys(app.callees), QB.webrtc.CallType.VIDEO); | ||
|
|
||
| isAudio = this.getAttribute('data-call') === 'audio'; |
Contributor
There was a problem hiding this comment.
Maybe better idea uses event object? Up to you
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Separate audio and video call buttons