allow for all names of tokens to be emitted #58
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hey @Quramy,
in this PR you will find a different emit style for type definitions, that would allow for all currently invalid tokens to be defined as well.
the emitted definition for the example would become:
which for currently valid tokens would be no change, yet invalid ones could also be consumed via index access like
styles['myclass-2']what do you think about this change. i could also make it optional, though the question would be if this is needed, as the new definition should be fully backward compatible.