Make src TypeScript #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 31, 2019 03:05
mohsen1
reviewed
May 31, 2019
Owner
|
It’s awesome! I’ll review this weekend :) |
Quramy
reviewed
Jun 2, 2019
| "resolveJsonModule": true, | ||
| "esModuleInterop": true, | ||
| "outDir": "lib" | ||
| }, |
Contributor
Author
There was a problem hiding this comment.
i also brought index.js to typescript, so that definitions can be consumed well.
Owner
|
@gdelmas |
added 2 commits
June 3, 2019 00:51
Contributor
Author
|
hey @Quramy, thanks for the review. i implemented the two changes from your comments. happy for the merge. |
Owner
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi @Quramy,
thought it would make sense to have a utility for typescript written in it as well.
while doing the typescript conversion i tried to change the syntax and spacing as little as possible to facilitate a code review.
is this something you would be open to merge?