-
Notifications
You must be signed in to change notification settings - Fork 69
Cleanup, async/await & let/const #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
52baf84 to
48fda1d
Compare
|
ahhh, i just noticed would you generally be open to the changes? i think it is nice as it reduces the lines of code, by keeping the functionality. |
|
hey @Quramy, what do you think about async/await? |
|
@gdelmas Sorry for my late reply 🙇 I like async/await syntax too. And for now unit testing is run in Node.js v6 env, but I think almost dev uses Node >= v8. So we no longer need to support v6. |
|
You can remove https://github.com/Quramy/typed-css-modules/blob/master/.travis.yml#L9 and use promisify. |
This reverts commit 7d4049f and disables running tests in travis on node 6 and specifies engine support in package.json
|
hey @Quramy, great to hear from you and happy you also like async/await better. you are completely right, without node6 support there is less code to maintain. i added a new commit to remove node6 support, where i also added the required node version to |
|
Thanks for your great work!!! |
|
I've published this as v0.5.0 🎉 |
|
amazing, thanks @Quramy |
hi @Quramy,
i made some further changes. mainly to async/await. but also some cleanup and the use of let/const.
for review it is probably worth looking at the changes at each commit one by one, as they are not a lot. the whole diff looks overwhelming and is not reflecting the steps well.