feature/strimzi-operator-connector #17
Conversation
pvannierop
force-pushed
the
feature/strimzi-operator-connector
branch
3 times, most recently
from
c99543c to
efa4876
Compare
pvannierop
force-pushed
the
feature/strimzi-operator-connector
branch
4 times, most recently
from
a8918af to
3bd1dc5
Compare
pvannierop
force-pushed
the
feature/strimzi-operator-connector
branch
from
3bd1dc5 to
14e11ec
Compare
|
|
||
| COPY --from=builder /code/build/libs/kafka-connect-transform-keyvalue*.jar /usr/share/"${COMPONENT}"/plugins/ | ||
| COPY ./docker/legacy/launch /etc/confluent/docker/launch | ||
| COPY ./docker/legacy/kafka-wait /usr/bin/kafka-wait |
There was a problem hiding this comment.
the relative paths here need to be updated, since this Dockerfile was also moved /docker/legacy
There was a problem hiding this comment.
I do not see this problem in line 5 and 6. What should I change?
There was a problem hiding this comment.
You're right, it is correct as is. I just assumed that since this Dockerfile was moved to /docker/legacy/, the build context would be also from inside that folder, so that the relative paths to launch and kafka-wait would be different (as it is in the same folder). I just realized that the project root needs to be kept as build context root in order to reach the /src/ location.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
ewelinagr
left a comment
ewelinagr
left a comment
There was a problem hiding this comment.
Small updates needed for /docker/legacy/Dockerfile.s3.
Maybe good to mention someting about the legacy vs strimzi images in the Readme?
|
I have also added a few lines about the ConfluentInc vs Strimzi connect support. |
pvannierop
force-pushed
the
feature/strimzi-operator-connector
branch
from
232e026 to
6e8e22c
Compare
This PR will: