236 #318
Merged
236 #318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added complete test coverage for src/turnkey/domain.rs: - Added 17 unit tests for TurnkeyErrorKind and TurnkeyError - Added 10 doctests for all public types and methods - Added module-level documentation - Tested Display implementations for both enum and struct - Tested Clone, PartialEq, Eq traits - Tested TurnkeyError::new with various input types - Verified map_turnkey_kind mappings Test results: - Unit tests: 386 passed (was 367, +19) - Doctests: 10 for turnkey::domain module - Clippy: no warnings - Formatting: compliant with rustfmt Coverage: - TurnkeyErrorKind: 100% - TurnkeyError: 100% - map_turnkey_kind: 100%
Added complete test coverage for src/turnkey/conversions.rs: - Added 14 unit tests for From trait implementations - Added 3 doctests for both conversion methods - Added module-level documentation with examples - Tested all TurnkeyErrorKind to AppErrorKind conversions - Tested all TurnkeyError to AppError conversions - Verified message preservation (empty, unicode, long messages) - Verified correct error kind mapping for all variants Test results: - Unit tests: 45 turnkey tests passed (was 31, +14) - Doctests: 3 for turnkey::conversions module - Clippy: no warnings - Formatting: compliant with rustfmt Coverage: - From<TurnkeyErrorKind> for AppErrorKind: 100% - From<TurnkeyError> for AppError: 100%
- Test all TurnkeyErrorKind to AppErrorKind conversions - Test all TurnkeyError to AppError conversions - Test edge cases: empty messages, long messages, unicode - Coverage: 33.33% -> 100%
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Comprehensive test coverage for
src/turnkey/conversions.rsto achieve 95%+ coverage target.Coverage Improvement
Before: 33.33% lines
After: 100% lines
Delta: +66.67%
Tests Added
TurnkeyErrorKind → AppErrorKind conversions
TurnkeyError → AppError conversions
Test Coverage
Verification
cargo test --lib turnkey::conversions cargo llvm-cov --all-features --workspaceCloses #236