Fix Preview Environment for multi-class objects #111#113
Merged
Ikuyadeu merged 1 commit intoREditorSupport:masterfrom Jul 19, 2019
Merged
Fix Preview Environment for multi-class objects #111#113Ikuyadeu merged 1 commit intoREditorSupport:masterfrom
Ikuyadeu merged 1 commit intoREditorSupport:masterfrom
Conversation
Member
|
@andycraig Great works! Thank you for your contribution! |
Member
|
I will publish this version after the security problem is solved. |
Collaborator
Author
|
@Ikuyadeu Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #111
Solution as suggested by @JimmyZJX - thank you! (I've applied it to
preview.tsrather thandist.js.)What problem did you solve?
R: Preview Environmentproduces strange results when objects have more than one class.Example (before PR) - note that
timeappears more than once in preview:(If you have)Screenshot
Example (after PR):
@Ikuyadeu I can build vscode-R successfully on commit 6411a58 but not on commits after that. I get build errors and can't run the unit tests with this version too, but it seems to run and it's only a one-line change so I'm going ahead with the PR.