Skip to content

Fix send code for newlines on Windows #114#125

Merged
Ikuyadeu merged 1 commit intoREditorSupport:masterfrom
andycraig:issue-114-newlines-windows
Sep 29, 2019
Merged

Fix send code for newlines on Windows #114#125
Ikuyadeu merged 1 commit intoREditorSupport:masterfrom
andycraig:issue-114-newlines-windows

Conversation

@andycraig
Copy link
Copy Markdown
Collaborator

Fixes #114

What problem did you solve?

Currently, blank lines that end in '\r\n' (common on Windows) are treated as not being blank, and are sent to the console by R: Run Selection/Line. This PR treats '\r' as whitespace, and so these lines are not sent to the console.

How can I check this pull request (on any OS)?

Create a file temp.R containing:

# Some blank lines


x <- 1

If 'LR' is displayed at the bottom right of the VSCode window, click on it and change the end of line sequence to 'CRLF'.

Use R: Run Selection/Line. Only x <- 1 is sent to the console.

@Ikuyadeu
Copy link
Copy Markdown
Member

@andycraig Thank you for your work!
I checked this.

@Ikuyadeu Ikuyadeu merged commit c033336 into REditorSupport:master Sep 29, 2019
@andycraig
Copy link
Copy Markdown
Collaborator Author

@Ikuyadeu Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Newlines when sending code to Radian

2 participants