Skip to content

Show WebView triggered by page_viewer in Active column#189

Merged
andycraig merged 1 commit intoREditorSupport:masterfrom
renkun-ken:page-viewer
Jan 24, 2020
Merged

Show WebView triggered by page_viewer in Active column#189
andycraig merged 1 commit intoREditorSupport:masterfrom
renkun-ken:page-viewer

Conversation

@renkun-ken
Copy link
Copy Markdown
Member

@renkun-ken renkun-ken commented Jan 16, 2020

Both viewer and page_viewer open WebView to show the resulted HTML file.

viewer is typically called by htmlwidgets to show a new page side-by-side with currently editing document while page_viewer (e.g. profvis) a new page in the current editor, which is consistent with RStudio behavior.

This PR distinguishes page_viewer and viewer by adding different viewColumn to the response they create and vscode-R handles them when updating response. Now, viewer uses viewColumn = "Two" while page_viewer uses viewColumn = "Active".

@andycraig
Copy link
Copy Markdown
Collaborator

@Ikuyadeu Can I suggest merging all of @renkun-ken's open PRs? I think it is okay not to test them, as currently these features are only visible to users who have enabled R: Session Watcher.

@Ikuyadeu
Copy link
Copy Markdown
Member

@andycraig OK! Thank you for reviewing!

@andycraig
Copy link
Copy Markdown
Collaborator

@Ikuyadeu Can I merge all of @renkun-ken’s open PRs?

@renkun-ken
Copy link
Copy Markdown
Member Author

It would be great if all my open PRs are merged since I'm constantly testing them in my work in my https://github.com/renkun-ken/vscode-R/tree/test branch which merges all my PRs whenever new commits are pushed to any of the PRs.

@Ikuyadeu
Copy link
Copy Markdown
Member

@andycraig Yes! of course.

@andycraig
Copy link
Copy Markdown
Collaborator

@Ikuyadeu Great, thank you! I will merge them now.

@renkun-ken Sorry, I should have mentioned that I think they're safe to merge because I know you're testing them continuously at work. Merging them now. Thank you for all these improvements to vscode-R!

@andycraig andycraig merged commit 15ef9ca into REditorSupport:master Jan 24, 2020
@Ikuyadeu
Copy link
Copy Markdown
Member

@andycraig Thank you! I will publish a new version this weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants