Show WebView triggered by page_viewer in Active column#189
Show WebView triggered by page_viewer in Active column#189andycraig merged 1 commit intoREditorSupport:masterfrom
Conversation
|
@Ikuyadeu Can I suggest merging all of @renkun-ken's open PRs? I think it is okay not to test them, as currently these features are only visible to users who have enabled |
|
@andycraig OK! Thank you for reviewing! |
|
@Ikuyadeu Can I merge all of @renkun-ken’s open PRs? |
|
It would be great if all my open PRs are merged since I'm constantly testing them in my work in my https://github.com/renkun-ken/vscode-R/tree/test branch which merges all my PRs whenever new commits are pushed to any of the PRs. |
|
@andycraig Yes! of course. |
|
@Ikuyadeu Great, thank you! I will merge them now. @renkun-ken Sorry, I should have mentioned that I think they're safe to merge because I know you're testing them continuously at work. Merging them now. Thank you for all these improvements to vscode-R! |
|
@andycraig Thank you! I will publish a new version this weekend. |
Both
viewerandpage_vieweropen WebView to show the resulted HTML file.vieweris typically called by htmlwidgets to show a new page side-by-side with currently editing document whilepage_viewer(e.g. profvis) a new page in the current editor, which is consistent with RStudio behavior.This PR distinguishes
page_viewerandviewerby adding differentviewColumnto the response they create and vscode-R handles them when updating response. Now,viewerusesviewColumn = "Two"whilepage_viewerusesviewColumn = "Active".