Skip to content

Added Dataviewer Command#20

Merged
Ikuyadeu merged 8 commits intoREditorSupport:masterfrom
Ladvien:master
Sep 3, 2017
Merged

Added Dataviewer Command#20
Ikuyadeu merged 8 commits intoREditorSupport:masterfrom
Ladvien:master

Conversation

@Ladvien
Copy link
Copy Markdown
Collaborator

@Ladvien Ladvien commented Aug 23, 2017

I've added a command which captures what is selected as the name of the dataframe, passes it to the RTerm to write as a CSV, polls the file size of the CSV to assure it is completely written, then opens the CSV, lastly, it uses the Excel Viewer csv.preview command to view the dataframe inside vscode.

There is a limitation of nothing larger than 5 MB dataframes due to vscode issue:

microsoft/vscode#32118

But this look it will be resolved during the next update. Currently, the Preview Dataframe command gracefully fails if dataframe exceeds 5 MB's, notifying the user of the limitation.

@Ikuyadeu Ikuyadeu self-requested a review August 23, 2017 23:53
@Ikuyadeu Ikuyadeu self-assigned this Aug 23, 2017
@Ikuyadeu
Copy link
Copy Markdown
Member

@Ladvien Thank you PR.
Looks good! But I can't review this week, sorry.
Please wait until next week.

@Ladvien
Copy link
Copy Markdown
Collaborator Author

Ladvien commented Aug 25, 2017

Ok, no worries.

@Ikuyadeu
Copy link
Copy Markdown
Member

@Ladvien Please delete .DS_Store or add this file in .gitignore.

@Ladvien
Copy link
Copy Markdown
Collaborator Author

Ladvien commented Aug 25, 2017

Done.

@Ikuyadeu Ikuyadeu merged commit 4ce1bd2 into REditorSupport:master Sep 3, 2017
@Ikuyadeu
Copy link
Copy Markdown
Member

Ikuyadeu commented Sep 3, 2017

Thank you @Ladvien!
Your submit is good always.
I want to send commit authority to you. How do you think?

Copy link
Copy Markdown
Member

@Ikuyadeu Ikuyadeu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very Good!

@Ladvien
Copy link
Copy Markdown
Collaborator Author

Ladvien commented Sep 4, 2017

Thank you! That'd be great--if you're OK with it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants