Avoid duplicate handling of response update#211
Merged
renkun-ken merged 2 commits intoREditorSupport:masterfrom Feb 2, 2020
Merged
Avoid duplicate handling of response update#211renkun-ken merged 2 commits intoREditorSupport:masterfrom
renkun-ken merged 2 commits intoREditorSupport:masterfrom
Conversation
Member
Author
|
It seems we only need the number of lines to change rather than increase to trigger handling response update. When user removes historic lines, the number of lines decreases. And appending new lines should also work then. |
11bb1bb to
1fc4a77
Compare
Member
|
@renkun-ken Thank you for your changes. From the next pull request, could you wait for the others review(me or @andycraig )? |
Member
Author
|
@Ikuyadeu Thanks for your reminder! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #205
Some software may watch a folder and modifies the file on file change in the folder, which causes a new line in
response.logto be handled multiple times.One example is OneDrive software under both Windows and macOS. It is constantly syncing a OneDrive folder. If a workspace folder in the OneDrive folder is open in VSCode, any update of
response.logwill result in duplicate handling, e.g.View(mtcars)creates multiple tabs of the same data.To avoid this, we record the number of lines of
response.logon each scan of the file. We only handle the last line when the number of linesincreasechanges. As a result, if a new line is appended toresponse.log, andupdateResponseis called multiple times due to the syncing may cause the file to be somehow updated multiple times, only the first time it is handled will take effect.