Skip to content

Fix handling grouped_df in dataview_table#248

Merged
renkun-ken merged 1 commit intoREditorSupport:masterfrom
renkun-ken:fix-247
Mar 7, 2020
Merged

Fix handling grouped_df in dataview_table#248
renkun-ken merged 1 commit intoREditorSupport:masterfrom
renkun-ken:fix-247

Conversation

@renkun-ken
Copy link
Copy Markdown
Member

What problem did you solve?

Closes #247

(If you do not have screenshot) How can I check this pull request?

library(dplyr)
mtcars %>% group_by(cyl) %>% View()

@renkun-ken
Copy link
Copy Markdown
Member Author

@intiben Would you like to test this with the build artifact at https://github.com/Ikuyadeu/vscode-R/pull/248/checks?

@ghost
Copy link
Copy Markdown

ghost commented Mar 4, 2020

@renkun-ken it works beautifully thanks a lot for addressing this issue!

@renkun-ken renkun-ken requested a review from andycraig March 4, 2020 13:09
@renkun-ken renkun-ken merged commit 8e76a9e into REditorSupport:master Mar 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

View() does play well with dplyr group_by()

1 participant