Skip to content

try to adding eslint#254

Merged
Ikuyadeu merged 2 commits intomasterfrom
eslint
Mar 9, 2020
Merged

try to adding eslint#254
Ikuyadeu merged 2 commits intomasterfrom
eslint

Conversation

@Ikuyadeu
Copy link
Copy Markdown
Member

@Ikuyadeu Ikuyadeu commented Mar 9, 2020 •
edited
Loading

What problem did you solve?

I added eslint for the future style.

How do you think the following works, and should I do them after merged?

  • remove tslint
  • replace GitHubAction tslint to eslint

@Ikuyadeu Ikuyadeu added the engineering Maintenance, style, development process label Mar 9, 2020
@renkun-ken
Copy link
Copy Markdown
Member

renkun-ken commented Mar 9, 2020

Replacing tslint with eslint might look better.

Would you mind I push to this PR branch to replace GitHubAction tslint to eslint?

@Ikuyadeu Ikuyadeu merged commit dcd5f90 into master Mar 9, 2020
@Ikuyadeu
Copy link
Copy Markdown
Member Author

Ikuyadeu commented Mar 9, 2020

@renkun-ken Thank you for your review.
In my plan, the current eslint rule should be tighter like previous tslint rules.

@Ikuyadeu Ikuyadeu deleted the eslint branch March 9, 2020 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

engineering Maintenance, style, development process

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Ikuyadeu @renkun-ken