Make plot update smarter using magic null dev size#274
Merged
renkun-ken merged 2 commits intoREditorSupport:masterfrom Apr 11, 2020
Merged
Make plot update smarter using magic null dev size#274renkun-ken merged 2 commits intoREditorSupport:masterfrom
renkun-ken merged 2 commits intoREditorSupport:masterfrom
Conversation
andycraig
approved these changes
Apr 11, 2020
Collaborator
|
@renkun-ken I tested this on Windows 10 and it works. If you are happy with it, please merge. |
Member
Author
|
Thanks for testing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem did you solve?
Closes #271
This PR makes plot update smarter using a magic null dev size so that we can check if the current device is the
NULLdevice we create as the default device to output graphics. I don't see if there's any better way to help us identify the device we create since user has very limited capability to set metadata and limited access to the information of a device.Now plot file is open only when graphics functions are called with the
NULLpdf device we create. Soknitr::knit()no longer triggers opening existing plot file, and user created device suchpngor otherpdfwill not setplot_updated = TRUEso VSCode won't copy the graphics from the current device.(If you have)Screenshot
(If you do not have screenshot) How can I check this pull request?
knitr::knit()doc1.Rmd) with the following content:knitr::knit("doc1.Rmd")plot(rnorm(10))and the plot file is open. Close this file.knitr::knit("doc1.Rmd")again and the previous plot file is not open.