Change so setting changes take effect immediately

[andycraig]

Closes #299

What problem did you solve?

Currently, changing a vscode-R setting requires a reload of the extension before the setting change takes effect. This PR makes setting changes take effect immediately.

How can I check this pull request?

Create a file temp.R with content

echo "Hello World"

Enable setting R: Always Use Active Terminal.

Open a terminal. Do NOT start R.

Ctrl+Enter in temp.R.

Observe that Hello World is sent to the terminal.

Disable setting R: Always Use Active Terminal.

Ctrl+Enter in temp.R.

Observe that a new R session starts in the terminal (with an error because echo is not valid R code).

Previously, R: Always Use Active Terminal would not have taken effect until the extension was reloaded (e.g., by restarting VS Code).

[andycraig]

I committed with unsaved changes to session.ts. I will force-push the changes to that.

[renkun-ken]

Another question is that it seems the config variable in utils.R (https://github.com/Ikuyadeu/vscode-R/pull/301/files#diff-8cd4968b81985f0efc2053eabc37db6dR7) seems no longer used any more. Should we clean it up and the imports?

[andycraig]

@renkun-ken Good catch! Will do.

[andycraig]

Hmm, we could retain the intention of config by changing it to a function instead of a variable.

[renkun-ken]

LGTM

[Ikuyadeu]

how is just change to

export const config = (function() {
    return workspace.getConfiguration('r');   
});

It will reduce whole of changes.
by calling

- config.get("")
- workspace.getConfiguration('r').get("")
+ config().get("")

[andycraig]

@Ikuyadeu Exactly, that's what I was thinking of.

[andycraig]

@Ikuyadeu

export const config = (function() {
    return workspace.getConfiguration('r');   
});

is better than

export function config() {
    return workspace.getConfiguration('r');
}

?

[renkun-ken]

Yes this looks better.

[Ikuyadeu]

I agree with you. My example was misleading between with function and variable

[andycraig]

Okay, I will change to this.

export function config() {
    return workspace.getConfiguration('r');
}

The commits are becoming a bit messy. I would like to tidy up using REBASE and FORCE PUSH. @Ikuyadeu @renkun-ken Do you approve rebase and force push here?

[Ikuyadeu]

In this case, Squash and Merge is better, it will combine your commits to the one.
After your change, I will merge it.

[andycraig]

@Ikuyadeu Okay, no rebase. Thanks in advance for squash and merge.

I will add the commit for config().

[renkun-ken]

I'm totally fine with both.

[andycraig]

Diff is much smaller now.

[Ikuyadeu]

Great!

[andycraig]

@Ikuyadeu @renkun-ken Thanks both!