Skip to content

Making the vscode-r original coding conventions#308

Merged
Ikuyadeu merged 2 commits intomasterfrom
devreplay
May 5, 2020
Merged

Making the vscode-r original coding conventions#308
Ikuyadeu merged 2 commits intomasterfrom
devreplay

Conversation

@Ikuyadeu
Copy link
Copy Markdown
Member

@Ikuyadeu Ikuyadeu commented May 5, 2020

What problem did you solve?
Related with #215 and microsoft/vscode#94751

I added my linter devreplay to verify the vscode-specific problems, such as #301

The deprecated functions are written on the devreplay.json

(If you have)Screenshot

I added bad syntax on the https://github.com/Ikuyadeu/vscode-R/compare/devreplay?expand=1#diff-f3fe9c4fe673e665c8df5914c3b9c9a0R333
After review, I will fix again that.

On the vscode:
May-05-2020 14-09-37

On the GitHub Action: https://github.com/Ikuyadeu/vscode-R/pull/308/checks

Screen Shot 2020-05-05 at 14 16 19

@andycraig @renkun-ken Could you check this?

@Ikuyadeu Ikuyadeu self-assigned this May 5, 2020
@andycraig
Copy link
Copy Markdown
Collaborator

@Ikuyadeu Interesting! How should we check this?

@renkun-ken
Copy link
Copy Markdown
Member

Looks quite interesting and useful. Is there anything we should do to check?

@Ikuyadeu
Copy link
Copy Markdown
Member Author

Ikuyadeu commented May 5, 2020

@andycraig @renkun-ken Thank you!
I just wanted to confirm that you will get interested in this or not.
I will merge this.

After merging this, you can get the lint result on vscode by installing vscode-devreplay.
And you can get the warning on the src/session.ts

@Ikuyadeu Ikuyadeu merged commit 413e545 into master May 5, 2020
@Ikuyadeu Ikuyadeu changed the title WIP: Making the vscode-r original coding conventions Making the vscode-r original coding conventions May 5, 2020
@Ikuyadeu Ikuyadeu deleted the devreplay branch May 5, 2020 12:45
@andycraig
Copy link
Copy Markdown
Collaborator

@Ikuyadeu Great! I’m looking forward to trying it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants