Skip to content

Added block detection and execute whole block#32

Merged
Ikuyadeu merged 2 commits intoREditorSupport:masterfrom
Ladvien:master
Nov 5, 2017
Merged

Added block detection and execute whole block#32
Ikuyadeu merged 2 commits intoREditorSupport:masterfrom
Ladvien:master

Conversation

@Ladvien
Copy link
Copy Markdown
Collaborator

@Ladvien Ladvien commented Oct 29, 2017

This PR provides functionality which should truly close #27.

If a partial block is selected, for example,

myFunction <- function() {
   foo$Bar <- "FooBar"
...

It should parse one line at a time until it finds the termination of the block.

It should also handle whole and half blocks.

myFunction <- function() {
   foo$Bar <- "FooBar"
}

myFunctionTwo <- function() {
   foo$Bar <- "FooBar"

And bidirectional block checking:

foo$Bar <- "FooBar"
}

myFunctionTwo <- function() {
   foo$Bar <- "FooBar"
}

Once I've received some feed back, I'll expand this to include looking at multiline functions. For example,

myFunction(x = 2,
                     y = 3)

@Ikuyadeu Ikuyadeu self-requested a review October 31, 2017 08:26
@Ikuyadeu Ikuyadeu self-assigned this Oct 31, 2017
@Ikuyadeu
Copy link
Copy Markdown
Member

@Ladvien Thank you for good PR!
I'll review this in this weekend.

@Ikuyadeu
Copy link
Copy Markdown
Member

Ikuyadeu commented Nov 5, 2017

OK, I checked.
Thank you good PR @Ladvien !

@Ikuyadeu Ikuyadeu merged commit a5313d4 into REditorSupport:master Nov 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Run line should load code chunk

2 participants