Added block detection and execute whole block#32
Merged
Ikuyadeu merged 2 commits intoREditorSupport:masterfrom Nov 5, 2017
Merged
Added block detection and execute whole block#32Ikuyadeu merged 2 commits intoREditorSupport:masterfrom
Ikuyadeu merged 2 commits intoREditorSupport:masterfrom
Conversation
Member
|
@Ladvien Thank you for good PR! |
Member
|
OK, I checked. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides functionality which should truly close #27.
If a partial block is selected, for example,
It should parse one line at a time until it finds the termination of the block.
It should also handle whole and half blocks.
And bidirectional block checking:
Once I've received some feed back, I'll expand this to include looking at multiline functions. For example,