supress auto-opening quote in roxygen comment#328
Merged
andycraig merged 1 commit intoREditorSupport:masterfrom May 23, 2020
gowerc:fix-roxygen-comment
Merged
supress auto-opening quote in roxygen comment#328andycraig merged 1 commit intoREditorSupport:masterfrom gowerc:fix-roxygen-comment
andycraig merged 1 commit intoREditorSupport:masterfrom
gowerc:fix-roxygen-comment
Conversation
Member
|
This works nicely. @andycraig Do you think if anything more should be added? |
Collaborator
|
@gowerc Thank you! @gowerc @renkun-ken I don't know of any way to automate a test for this either so I don't think anything else needs to be added. |
andycraig
approved these changes
May 23, 2020
Collaborator
|
LGTM. Thank you @gowerc! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem did you solve?
#327
(If you have)Screenshot
Gif to show change still allows single quotes to auto complete when not following a # symbol
Couldn't find any related tests connect to auto-bracketing but please let me know if there are some that I've missed.
Couldn't see anyway of adding context to the auto-bracketing file so decided to make a new auto-bracket specifically for roxygen comments which simply doesn't have any closing tag. Please let me know if there is a better way of doing this